Clarify that command-line switches need to be manually set in addprocs#50843
Clarify that command-line switches need to be manually set in addprocs#50843inkydragon merged 4 commits intoJuliaLang:masterfrom
addprocs#50843Conversation
|
There's three (!) unrelated changes in this PR. Why don't you separate the other two fixes into separate PRs? |
|
Regarding the main change, it's a duplicate of #50480 |
I'd argue that there is a single main change, documenting how --heap-size-hint (and other flags) work with addproces. That requires adding --heap-size-hint to the docs itself. The only unrelated change is a one character typo fix that I came across, and I didn't feel it would block this PR, so I included it. I'm happy to split it out to another PR if requested.
I missed this PR by @KnutAM, nice work! Note it's not the main change in this PR, I'd say that's the interaction with addprocs. |
|
Unfortunately this now has a conflict. @evetion would you be willing to resolve that. I think afterwards (and with my other comment taken into account) I think this is in a good shape for merging? |
Co-authored-by: Max Horn <max@quendi.de>
Originally proposed in JuliaLang/julia#50843
Fixed now, and moved part of the PR to the Distributed package. |
Originally proposed in JuliaLang/julia#50843
inkydragon
left a comment
There was a problem hiding this comment.
It looks like the current changes have nothing to do with --heap-size-hint, maybe a title change is needed, then LGTM.
addprocsaddprocs
Thanks for the suggestion, I've updated the title. |
…ng#14) Originally proposed in JuliaLang/julia#50843
Fixes #50673
also fixed a small typo in an unrelated doc page.