Skip to content

Ensure that new GC tests actually succeed#49579

Merged
vchuravy merged 4 commits intomasterfrom
vc/err_check_gc_tests
May 2, 2023
Merged

Ensure that new GC tests actually succeed#49579
vchuravy merged 4 commits intomasterfrom
vc/err_check_gc_tests

Conversation

@vchuravy
Copy link
Copy Markdown
Member

@vchuravy vchuravy commented May 1, 2023

No description provided.

@vchuravy vchuravy added test This change adds or pertains to unit tests GC Garbage collector embarrassing-bugfix Whoops! labels May 1, 2023
@vchuravy vchuravy requested review from d-netto and gbaraldi May 1, 2023 01:41
d-netto
d-netto reviewed May 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have a test that exercises chunking of ary8/ary16. The MWE from #49501 could serve as an inspiration.

@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented May 1, 2023 

gc                                                (8) |        started at 2023-05-01T02:21:38.704
 From worker 8:	fatal: error thrown and no exception handler available.
      From worker 8:	OutOfMemoryError()
      From worker 8:	unknown function (ip: 7498990e)
      From worker 8:	unknown function (ip: 7497a12b)
      From worker 8:	unknown function (ip: 74986a08)
      From worker 8:	unknown function (ip: 7498723d)
      From worker 8:	unknown function (ip: 7494b4d3)
      From worker 8:	unknown function (ip: 7494c4d8)
      From worker 8:	unknown function (ip: 74978408)
      From worker 8:	unknown function (ip: 09a5a529)
      From worker 8:	unknown function (ip: 09731104)
      From worker 8:	unknown function (ip: 0973130d)
      From worker 8:	unknown function (ip: 749293d8)
      From worker 8:	unknown function (ip: 7498f33c)
      From worker 8:	unknown function (ip: 7498fca9)
      From worker 8:	jl_load_repl at C:/workdir/cli\loader_lib.c:561
      From worker 8:	mainCRTStartup at C:/workdir/cli\loader_exe.c:58
      From worker 8:	unknown function (ip: 75d06a38)
      From worker 8:	unknown function (ip: 778f7c9c)
      From worker 8:	unknown function (ip: 778f7c6a)

So maybe we need to make the tests even smaller?

@gbaraldi
Copy link
Copy Markdown
Member

gbaraldi commented May 1, 2023

Only on 32 bit probably

@vchuravy vchuravy force-pushed the vc/err_check_gc_tests branch from 7956bf6 to f5a45bd Compare May 1, 2023 14:56
@vchuravy vchuravy changed the title Ensure that new GC tests succeed Ensure that new GC tests actually succeed May 1, 2023
@vchuravy vchuravy merged commit 0b0ae1a into master May 2, 2023
@vchuravy vchuravy deleted the vc/err_check_gc_tests branch May 2, 2023 01:07
@d-netto d-netto mentioned this pull request May 2, 2023
Merged
udesou pushed a commit to udesou/julia that referenced this pull request Jan 25, 2024
@vchuravy @udesou
Ensure that new GC tests actually succeed (JuliaLang#49579)
0c88763
udesou added a commit to mmtk/julia that referenced this pull request Jan 25, 2024
@udesou
Merge pull request #33 from udesou/fix/gc-tests
dac3a35 
Cherry-picking Ensure that new GC tests actually succeed (JuliaLang#49579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-netto d-netto d-netto left review comments

@gbaraldi gbaraldi Awaiting requested review from gbaraldi

Assignees

No one assigned

Labels

embarrassing-bugfix Whoops! GC Garbage collector test This change adds or pertains to unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vchuravy @gbaraldi @d-netto