Merged
Conversation
45b8a84 to
a2ddf28
Compare
vtjnash
reviewed
Sep 26, 2022
Member
vtjnash
left a comment
There was a problem hiding this comment.
Normally this is handled for invoke cases by calling jl_gf_invoke_lookup_worlds, since it is not typically that logical to return a list of things equal to some other thing, as there can only be zero or one of them.
This fixes backedge-based invalidation when a precompiled `invoke` is followed by loading a package that adds new specializations for the `invoke`d method. An example is LowRankApprox.jl, where FillArrays adds a specialization to `unique`.
a2ddf28 to
f6badbd
Compare
Member
Author
|
Thanks! I stripped out the changes to |
vtjnash
approved these changes
Sep 26, 2022
This comment was marked as outdated.
This comment was marked as outdated.
vtjnash
pushed a commit
that referenced
this pull request
Sep 27, 2022
This fixes backedge-based invalidation when a precompiled `invoke` is followed by loading a package that adds new specializations for the `invoke`d method. An example is LowRankApprox.jl, where FillArrays adds a specialization to `unique`.
vtjnash
pushed a commit
that referenced
this pull request
Nov 29, 2022
This fixes backedge-based invalidation when a precompiled `invoke` is followed by loading a package that adds new specializations for the `invoke`d method. An example is LowRankApprox.jl, where FillArrays adds a specialization to `unique`. (cherry picked from commit 698beed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes backedge-based invalidation when a precompiled
invokeis followed by loading a package that adds new specializations for theinvoked function. An example is LowRankApprox.jl, where FillArrays adds a specialization touniquewhichinvokesuniquefor an arbitraryitr. CC @jishnub.This also allows one to setintersections=falseso that one can compute matching methods forinvokecalls.