Profile: Stop allocation profiler even on error#44045
Merged
NHDaly merged 1 commit intoJuliaLang:masterfrom Feb 5, 2022
Merged
Profile: Stop allocation profiler even on error#44045NHDaly merged 1 commit intoJuliaLang:masterfrom
NHDaly merged 1 commit intoJuliaLang:masterfrom
Conversation
vilterp
approved these changes
Feb 5, 2022
Contributor
vilterp
left a comment
There was a problem hiding this comment.
Oh, nice, thanks! Looks good to me.
NHDaly
approved these changes
Feb 5, 2022
Member
NHDaly
left a comment
There was a problem hiding this comment.
Haha whoops! Great call. Thanks Ian!
LGTM
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops the allocation profiler on error as well as return.
I noticed this because interrupting a run left the system sluggish
cc. @NHDaly @vilterp