Conversation
Sacha0
approved these changes
Jan 6, 2022
Member
Sacha0
left a comment
There was a problem hiding this comment.
Looks great assuming CI is happy! :)
ararslan
reviewed
Jan 6, 2022
| #define STR(csym) #csym | ||
| #define XSTR(csym) STR(csym) | ||
| #include "julia.h" | ||
| #include "llvm-version.h" |
Member
There was a problem hiding this comment.
So this is no longer needed since now the files that include it are expected to already have included llvm-version?
Member
Author
There was a problem hiding this comment.
yes, that is how we generally expect these headers to be used
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.