Skip to content

Add get_preferences() to load all prefs in the current environment#43684

Merged
vchuravy merged 1 commit intomasterfrom
sf/preference_loading
Jan 9, 2022
Merged

Add get_preferences() to load all prefs in the current environment#43684
vchuravy merged 1 commit intomasterfrom
sf/preference_loading

Conversation

@staticfloat
Copy link
Copy Markdown
Member

Previously, we had the machinery to load per-UUID, but some tooling
needs to be able to load all preferences (without loading
Preferences.jl), so it's better to support being able to load
everything from just within Base.

Also add some preference loading tests, so that we can fearlessly
refactor this code in the future.

@staticfloat staticfloat requested a review from vchuravy January 6, 2022 20:07
@KristofferC
Copy link
Copy Markdown
Member

, but some tooling
needs to be able to load all preferences (without loading
Preferences.jl), so it's better to support being able to load
everything from just within Base.

What tooling?

@vchuravy
Copy link
Copy Markdown
Member

vchuravy commented Jan 6, 2022

What tooling?

Elliot wrote this for JuliaLang/Pkg.jl#2920

@vchuravy vchuravy closed this Jan 8, 2022
@vchuravy vchuravy reopened this Jan 8, 2022
@vchuravy vchuravy force-pushed the sf/preference_loading branch from 7a8613f to 8c8195f Compare January 8, 2022 20:37
Previously, we had the machinery to load per-UUID, but some tooling
needs to be able to load all preferences (without loading
`Preferences.jl`), so it's better to support being able to load
everything from just within Base.

Also add some preference loading tests, so that we can fearlessly
refactor this code in the future.
@vchuravy vchuravy merged commit cd81054 into master Jan 9, 2022
@vchuravy vchuravy deleted the sf/preference_loading branch January 9, 2022 03:44
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…uliaLang#43684)

Previously, we had the machinery to load per-UUID, but some tooling
needs to be able to load all preferences (without loading
`Preferences.jl`), so it's better to support being able to load
everything from just within Base.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…uliaLang#43684)

Previously, we had the machinery to load per-UUID, but some tooling
needs to be able to load all preferences (without loading
`Preferences.jl`), so it's better to support being able to load
everything from just within Base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants