Add missing include of llvm-version.h in codegen_shared.h#43683
Merged
Add missing include of llvm-version.h in codegen_shared.h#43683
Conversation
Without this, `JL_LLVM_VERSION` is undefined and defaults to 0, so the branch for older LLVM is always taken.
vchuravy
approved these changes
Jan 6, 2022
Member
|
Now why are you running on LLVM 14 already xD |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jpsamaroo
pushed a commit
to jpsamaroo/julia
that referenced
this pull request
Jan 21, 2022
…43683) Without this, `JL_LLVM_VERSION` is undefined and defaults to 0, so the branch for older LLVM is always taken.
jpsamaroo
pushed a commit
to jpsamaroo/julia
that referenced
this pull request
Feb 7, 2022
…43683) Without this, `JL_LLVM_VERSION` is undefined and defaults to 0, so the branch for older LLVM is always taken.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…43683) Without this, `JL_LLVM_VERSION` is undefined and defaults to 0, so the branch for older LLVM is always taken.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…43683) Without this, `JL_LLVM_VERSION` is undefined and defaults to 0, so the branch for older LLVM is always taken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this,
JL_LLVM_VERSIONis undefined and defaults to 0, so the branch for older LLVM is always taken.