Don't set HAVE_SSP unconditionally on aarch64#43555
Merged
vtjnash merged 1 commit intoJuliaLang:masterfrom Jan 7, 2022
Merged
Conversation
There is no plausible reason for this. And indeed, this patch fixes compilation for the libjulia_jll builder on Yggdrasil which currently fails due to the absence of libssp. The removed line was introduced in PR JuliaLang#41936 but without any justification that I could discern, so it might have just slipped in there accidentally.
23 tasks
Member
|
I think this is good to land, but I would appreciate a comment from someone who know ARM better than me xD |
Member
|
No need to backport since it was added in 628209c. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
There is no plausible reason for this. And indeed, this patch fixes compilation for the libjulia_jll builder on Yggdrasil which currently fails due to the absence of libssp. The removed line was introduced in PR JuliaLang#41936 but without any justification that I could discern, so it might have just slipped in there accidentally.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
There is no plausible reason for this. And indeed, this patch fixes compilation for the libjulia_jll builder on Yggdrasil which currently fails due to the absence of libssp. The removed line was introduced in PR JuliaLang#41936 but without any justification that I could discern, so it might have just slipped in there accidentally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no plausible reason for this. And indeed, this patch fixes compilation for the libjulia_jll builder on Yggdrasil which currently fails due to the absence of libssp. Apparently also issue #43071 was caused by this.
The removed line was introduced in PR #41936 (by @JeffBezanson) but without any justification that I could discern, so it might have just slipped in there accidentally.
CC @giordano