IRShow: use IOContext for PhiNodes/:invoke printing#43226
Merged
Conversation
In order to allow `Argument`s to be printed nicely.
> before
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(_2::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any
└── return %4
) => Any
```
> after
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(x::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => x, #3 => y)::Any
└── return %4
) => Any
```
simeonschaub
approved these changes
Nov 26, 2021
Member
simeonschaub
left a comment
There was a problem hiding this comment.
Good catch! Might want to backport this as well?
Member
Author
|
Maybe backport to both 1.6 and 1.7? |
Member
|
Yes, I'd imagine that this was broken for quite a while. |
Member
Author
|
okay, I added the labels. |
aviatesk
added a commit
that referenced
this pull request
Nov 26, 2021
In order to allow `Argument`s to be printed nicely.
> before
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(_2::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any
└── return %4
) => Any
```
> after
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(x::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => x, #3 => y)::Any
└── return %4
) => Any
```
This was referenced Nov 26, 2021
aviatesk
added a commit
that referenced
this pull request
Nov 26, 2021
In order to allow `Argument`s to be printed nicely.
> before
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(_2::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any
└── return %4
) => Any
```
> after
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(x::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => x, #3 => y)::Any
└── return %4
) => Any
```
Member
Author
|
Done backports. |
KristofferC
pushed a commit
that referenced
this pull request
Nov 26, 2021
In order to allow `Argument`s to be printed nicely.
> before
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(_2::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any
└── return %4
) => Any
```
> after
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(x::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => x, #3 => y)::Any
└── return %4
) => Any
```
KristofferC
pushed a commit
that referenced
this pull request
Nov 26, 2021
In order to allow `Argument`s to be printed nicely.
> before
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(_2::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any
└── return %4
) => Any
```
> after
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(x::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => x, #3 => y)::Any
└── return %4
) => Any
```
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…43226) In order to allow `Argument`s to be printed nicely. > before ```julia julia> code_typed((Float64,)) do x sin(x) end 1-element Vector{Any}: CodeInfo( 1 ─ %1 = invoke Main.sin(_2::Float64)::Float64 └── return %1 ) => Float64 julia> code_typed((Bool,Any,Any)) do c, x, y z = c ? x : y z end 1-element Vector{Any}: CodeInfo( 1 ─ goto #3 if not c 2 ─ goto #4 3 ─ nothing::Nothing 4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any └── return %4 ) => Any ``` > after ```julia julia> code_typed((Float64,)) do x sin(x) end 1-element Vector{Any}: CodeInfo( 1 ─ %1 = invoke Main.sin(x::Float64)::Float64 └── return %1 ) => Float64 julia> code_typed((Bool,Any,Any)) do c, x, y z = c ? x : y z end 1-element Vector{Any}: CodeInfo( 1 ─ goto #3 if not c 2 ─ goto #4 3 ─ nothing::Nothing 4 ┄ %4 = φ (#2 => x, #3 => y)::Any └── return %4 ) => Any ```
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…43226) In order to allow `Argument`s to be printed nicely. > before ```julia julia> code_typed((Float64,)) do x sin(x) end 1-element Vector{Any}: CodeInfo( 1 ─ %1 = invoke Main.sin(_2::Float64)::Float64 └── return %1 ) => Float64 julia> code_typed((Bool,Any,Any)) do c, x, y z = c ? x : y z end 1-element Vector{Any}: CodeInfo( 1 ─ goto #3 if not c 2 ─ goto #4 3 ─ nothing::Nothing 4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any └── return %4 ) => Any ``` > after ```julia julia> code_typed((Float64,)) do x sin(x) end 1-element Vector{Any}: CodeInfo( 1 ─ %1 = invoke Main.sin(x::Float64)::Float64 └── return %1 ) => Float64 julia> code_typed((Bool,Any,Any)) do c, x, y z = c ? x : y z end 1-element Vector{Any}: CodeInfo( 1 ─ goto #3 if not c 2 ─ goto #4 3 ─ nothing::Nothing 4 ┄ %4 = φ (#2 => x, #3 => y)::Any └── return %4 ) => Any ```
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
In order to allow `Argument`s to be printed nicely.
> before
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(_2::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => _3, #3 => _4)::Any
└── return %4
) => Any
```
> after
```julia
julia> code_typed((Float64,)) do x
sin(x)
end
1-element Vector{Any}:
CodeInfo(
1 ─ %1 = invoke Main.sin(x::Float64)::Float64
└── return %1
) => Float64
julia> code_typed((Bool,Any,Any)) do c, x, y
z = c ? x : y
z
end
1-element Vector{Any}:
CodeInfo(
1 ─ goto #3 if not c
2 ─ goto #4
3 ─ nothing::Nothing
4 ┄ %4 = φ (#2 => x, #3 => y)::Any
└── return %4
) => Any
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow
Arguments to be printed nicely.