Skip to content

When giving - as the program, read code from standard in.#43191

Merged
vtjnash merged 1 commit intomasterfrom
fe/stdin-program
Jan 12, 2022
Merged

When giving - as the program, read code from standard in.#43191
vtjnash merged 1 commit intomasterfrom
fe/stdin-program

Conversation

@fredrikekre
Copy link
Copy Markdown
Member

@fredrikekre fredrikekre commented Nov 22, 2021

I couldn't figure out another way of passing args while reading from stdin. This seems to be what python does (for example):

$ julia - foo bar <<EOF
println(ARGS)
EOF
["foo", "bar"]

$ python - foo bar <<EOF
import sys; print(sys.argv)
EOF
['-', 'foo', 'bar']

It is perhaps a bit strange that this takes another code path compared to

julia <<EOF
...
EOF

since that ends up all the way in here:

julia/base/client.jl

Line 412 in ae336ab

if isa(input, File) || isa(input, IOStream)
but not sure it matters much.

@fredrikekre fredrikekre changed the title When giving - as the program, read program from standard in. When giving - as the program, read code from standard in. Nov 22, 2021
@StefanKarpinski StefanKarpinski added the minor change Marginal behavior change acceptable for a minor release label Nov 22, 2021
@Keno
Copy link
Copy Markdown
Member

Keno commented Nov 23, 2021 

julia <<EOF
...
EOF

Shouldn't we just make this work? If we're already autoswitching based on stream type detection, why not at least make it useful.

@fredrikekre
Copy link
Copy Markdown
Member Author

fredrikekre commented Nov 23, 2021

Shouldn't we just make this work?

It does work, just ends up taking a different path than what I implemented here.

@fredrikekre
Copy link
Copy Markdown
Member Author

fredrikekre commented Jan 10, 2022

Bump.

@vtjnash vtjnash merged commit 98e2321 into master Jan 12, 2022
@vtjnash vtjnash deleted the fe/stdin-program branch January 12, 2022 00:13
@maleadt
Copy link
Copy Markdown
Member

maleadt commented Jan 12, 2022

I guess this can now be changed to passing -?

julia/base/loading.jl

Lines 1406 to 1413 in 2ed3ec4

io = open(pipeline(`$(julia_cmd()::Cmd) -O0
--output-ji $output --output-incremental=yes
--startup-file=no --history-file=no --warn-overwrite=yes
--color=$(have_color === nothing ? "auto" : have_color ? "yes" : "no")
$trace
--eval 'eval(Meta.parse(read(stdin,String)))'`, stderr = internal_stderr, stdout = internal_stdout),
"w", stdout)
# write data over stdin to avoid the (unlikely) case of exceeding max command line size

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Jan 12, 2022

True, that would seem to be identical now

@maleadt maleadt mentioned this pull request Jan 18, 2022
Merged
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@fredrikekre @LilithHafner
When given - as the program name, read program from stdin (JuliaLang#…
5ebe36d 
…43191)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@fredrikekre @LilithHafner
When given - as the program name, read program from stdin (JuliaLang#…
75eeea7 
…43191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees

No one assigned

Labels

minor change Marginal behavior change acceptable for a minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fredrikekre @Keno @maleadt @vtjnash @StefanKarpinski