Merged
Conversation
Previously, we needed to provide both `usr/lib` and `usr/lib/julia` as elements on the `RPATH`, because `libjulia` lived in `usr/lib`, and needed to be able to find dependent libraries both within a build tree (when most libraries live in `usr/lib`) and within an install tree (when most libraries live in `usr/lib/julia`). Nowadays, everything is either in `usr/lib` or in `usr/lib/julia` with the exception of `libjulia`, but since it's really `libjulia-internal` that does all the `dlopen()`'ing, we can simply use `$$ORIGIN` (or the equivalent `@loader_path/` on macOS) and completely ignore the rest of the RPATH shenanigans we do.
vtjnash
approved these changes
Nov 3, 2021
Member
|
This broke FreeBSD (more so than it already was): https://build.julialang.org/#/builders/78/builds/4690/steps/5/logs/stdio. Seems one or more of those removed rpath specifications is required. |
Member
|
It also broke musl: #42940 |
Member
|
@staticfloat @vtjnash Could we revert this to fix #42944 and #42940, and then reland a fixed version later? |
Member
|
Oh, hmmm. Would reverting this PR break Julia on macOS Monterey? |
Member
|
We can probably keep the change that affects macOS and revert the part that doesn't. (The changes reflected in the diff are in two different |
ararslan
added a commit
that referenced
this pull request
Nov 6, 2021
The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in #42919 that affect other platforms seem to have caused regressions on musl Linux (#42940) and FreeBSD (#42944). The easiest thing to do here is to keep the changes from #42919 as they apply to macOS but revert the others.
staticfloat
pushed a commit
that referenced
this pull request
Nov 6, 2021
* Partially revert #42919 The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in #42919 that affect other platforms seem to have caused regressions on musl Linux (#42940) and FreeBSD (#42944). The easiest thing to do here is to keep the changes from #42919 as they apply to macOS but revert the others. * Un-revert the `RPATH_LIB` definition
Member
|
Should the macOS specific part of this be backported to 1.6/1.7 for Monterey support or should this one not affect it? |
KristofferC
pushed a commit
that referenced
this pull request
Nov 7, 2021
Previously, we needed to provide both `usr/lib` and `usr/lib/julia` as elements on the `RPATH`, because `libjulia` lived in `usr/lib`, and needed to be able to find dependent libraries both within a build tree (when most libraries live in `usr/lib`) and within an install tree (when most libraries live in `usr/lib/julia`). Nowadays, everything is either in `usr/lib` or in `usr/lib/julia` with the exception of `libjulia`, but since it's really `libjulia-internal` that does all the `dlopen()`'ing, we can simply use `$$ORIGIN` (or the equivalent `@loader_path/` on macOS) and completely ignore the rest of the RPATH shenanigans we do. (cherry picked from commit 236523f)
KristofferC
pushed a commit
that referenced
this pull request
Nov 7, 2021
* Partially revert #42919 The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in #42919 that affect other platforms seem to have caused regressions on musl Linux (#42940) and FreeBSD (#42944). The easiest thing to do here is to keep the changes from #42919 as they apply to macOS but revert the others. * Un-revert the `RPATH_LIB` definition (cherry picked from commit 653cad3)
66 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Previously, we needed to provide both `usr/lib` and `usr/lib/julia` as elements on the `RPATH`, because `libjulia` lived in `usr/lib`, and needed to be able to find dependent libraries both within a build tree (when most libraries live in `usr/lib`) and within an install tree (when most libraries live in `usr/lib/julia`). Nowadays, everything is either in `usr/lib` or in `usr/lib/julia` with the exception of `libjulia`, but since it's really `libjulia-internal` that does all the `dlopen()`'ing, we can simply use `$$ORIGIN` (or the equivalent `@loader_path/` on macOS) and completely ignore the rest of the RPATH shenanigans we do.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* Partially revert JuliaLang#42919 The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in JuliaLang#42919 that affect other platforms seem to have caused regressions on musl Linux (JuliaLang#42940) and FreeBSD (JuliaLang#42944). The easiest thing to do here is to keep the changes from JuliaLang#42919 as they apply to macOS but revert the others. * Un-revert the `RPATH_LIB` definition
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Previously, we needed to provide both `usr/lib` and `usr/lib/julia` as elements on the `RPATH`, because `libjulia` lived in `usr/lib`, and needed to be able to find dependent libraries both within a build tree (when most libraries live in `usr/lib`) and within an install tree (when most libraries live in `usr/lib/julia`). Nowadays, everything is either in `usr/lib` or in `usr/lib/julia` with the exception of `libjulia`, but since it's really `libjulia-internal` that does all the `dlopen()`'ing, we can simply use `$$ORIGIN` (or the equivalent `@loader_path/` on macOS) and completely ignore the rest of the RPATH shenanigans we do.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* Partially revert JuliaLang#42919 The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in JuliaLang#42919 that affect other platforms seem to have caused regressions on musl Linux (JuliaLang#42940) and FreeBSD (JuliaLang#42944). The easiest thing to do here is to keep the changes from JuliaLang#42919 as they apply to macOS but revert the others. * Un-revert the `RPATH_LIB` definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we needed to provide both
usr/libandusr/lib/juliaaselements on the
RPATH, becauselibjulialived inusr/lib, andneeded to be able to find dependent libraries both within a build tree
(when most libraries live in
usr/lib) and within an install tree (whenmost libraries live in
usr/lib/julia).Nowadays, everything is either in
usr/libor inusr/lib/juliawiththe exception of
libjulia, but since it's reallylibjulia-internalthat does all the
dlopen()'ing, we can simply use$$ORIGIN(or theequivalent
@loader_path/on macOS) and completely ignore the rest ofthe RPATH shenanigans we do.