late-gc-lowering: Prevent infinite recursion#42445
Merged
Conversation
Phi nodes are allowed to recursively depend on themselves, so we need to keep track of which ones we have seen to avoid an infinite recursion here. Apparently this doesn't usually come up, but I did see if with tsan enabled.
vtjnash
approved these changes
Oct 1, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jan 11, 2022
Phi nodes are allowed to recursively depend on themselves, so we need to keep track of which ones we have seen to avoid an infinite recursion here. Apparently this doesn't usually come up, but I did see if with tsan enabled. (cherry picked from commit a9a1d80)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Phi nodes are allowed to recursively depend on themselves, so we need to keep track of which ones we have seen to avoid an infinite recursion here. Apparently this doesn't usually come up, but I did see if with tsan enabled.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Phi nodes are allowed to recursively depend on themselves, so we need to keep track of which ones we have seen to avoid an infinite recursion here. Apparently this doesn't usually come up, but I did see if with tsan enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phi nodes are allowed to recursively depend on themselves, so
we need to keep track of which ones we have seen to avoid an
infinite recursion here. Apparently this doesn't usually come
up, but I did see if with tsan enabled.