inference: improve the robustness of getfield_tfunc#42378
Merged
Conversation
vtjnash
approved these changes
Sep 24, 2021
I found `getfield_tfunc` can easily throw on this code path. In the added test case, I intentionally formed `PartialStruct` as an example target that can cause an error, but the same thing can happen for other arbitrary `CompilerTypes` objects.
92b87a7 to
02de9f1
Compare
DilumAluthge
added a commit
that referenced
this pull request
Sep 26, 2021
This reverts commit 53aa65a.
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
I found `getfield_tfunc` can easily throw on this code path. In the added test case, I intentionally used `PartialStruct` as an example target that can cause an error, but the same thing can happen for other arbitrary `CompilerTypes` objects.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
I found `getfield_tfunc` can easily throw on this code path. In the added test case, I intentionally used `PartialStruct` as an example target that can cause an error, but the same thing can happen for other arbitrary `CompilerTypes` objects.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
I found `getfield_tfunc` can easily throw on this code path. In the added test case, I intentionally used `PartialStruct` as an example target that can cause an error, but the same thing can happen for other arbitrary `CompilerTypes` objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found
getfield_tfunccan easily throw on this code path.In the added test case, I intentionally formed
PartialStructas anexample target that can cause an error, but the same thing can happen
for other arbitrary
CompilerTypesobjects.