Base.runtests: set a temporary Pkg depot path#42358
Conversation
|
Would be good to say something in the commit message why this is needed now. Something with Buildkite? |
|
Buildbot, actually. This fixes one source of intermittent Buildbot failures. More context on Slack: https://julialang.slack.com/archives/C01F9PX2UMU/p1632263882053700
|
vtjnash
left a comment
There was a problem hiding this comment.
I think we also need to set JULIA_PROJECT?
Hmmm, I don't think we need to. If |
vtjnash
left a comment
There was a problem hiding this comment.
Does buildbot / buildkite use this code? I thought they generally launched the runtests.jl file directly (and avoided the ncores /= 2here).
|
I'm not sure about Buildbot - @staticfloat will know. Buildkite calls |
|
Yes, buildbot uses |
Does it? At least for me, this PR breaks the (@v1.8) pkg> st
Status `~/.julia/environments/v1.8/Project.toml`
[6e4b80f9] BenchmarkTools v1.2.0
[33e6dc65] MKL v0.4.2
[295af30f] Revise v3.1.20
julia> Base.runtests("ranges", revise=true)
ERROR: LoadError: ArgumentError: Package Revise not found in current path.
- Run `import Pkg; Pkg.add("Revise")` to install the Revise package.
Stacktrace:
[1] require(into::Module, mod::Symbol)
@ Base ./loading.jl:989
[2] top-level scope
@ ~/Development/julia/usr/share/julia/test/runtests.jl:26
in expression starting at /home/sebastian/Development/julia/usr/share/julia/test/runtests.jl:25 |
* set JULIA_DEPOT_PATH when conda env activated * simplify recipe and add back up variables * don't run juliarc.jl * improve activate.d/deactivate.d file editing * Apply suggestions from code review by @mkitti * This uses the activate.sh and deactivate.sh scripts that backup the environment variable. * Create a new shared environment located in the site depot for the environment rather than continuing to use the default one in ~/.julia/environments/v#.#. * reorganize * increase bld no * try building osx with system mbedtls * only apply three new patches to linux for now * reorganize order of patches * Revert "try building osx with system mbedtls" This reverts commit 1b1d170. * comment out juliarc.jl * Update build.sh * try runtests math for osx * test "opaque_closure", "filesystem" * go all in on testing * revert previous; parallelize + add "math" to list - use all processors: ncores=ceil(Int, Sys.CPU_THREADS - move math up to regular tests (no longer necessary to stop it from running on osx) * Update build.sh * Update activate.sh * Revert "Update activate.sh" This reverts commit fe2b9c9. * new patches * correct patches in meta * change of patches * Update meta.yaml * Modify patch to match upstream JuliaLang/julia#42358. Use addenv. * Re-add JULIA_PROJECT to be "@$CONDA_DEFAULT_ENV" * Revert "Re-add JULIA_PROJECT to be "@$CONDA_DEFAULT_ENV"" This reverts commit 1e312a1. * Set JULIA_PROJECT and JULIA_LOAD_PATH according to conda environment * Test loading and cmdlineargs with default JULIA_PROJECT * Extract env name as last directory of CONDA_PREFIX * Remove JULIA_LOAD_PATH while testing loading * Update build.sh * Delete recipe/old_unused directory * reorganize patches and delete unnecessary files * remove DS_STORE * oops place back patches * Apply suggestions from code review, remove "unique" Co-authored-by: ngam <67342040+ngam@users.noreply.github.com> Co-authored-by: Matt Johnson <mjohnson541@gmail.com> Co-authored-by: Mark Kittisopikul <mkitti@users.noreply.github.com> Co-authored-by: Mark Kittisopikul <markkitt@gmail.com>
(cherry picked from commit 2c9e051)
(cherry picked from commit 2c9e051)
(cherry picked from commit 2c9e051)
(cherry picked from commit 2c9e051)
No description provided.