Skip to content

CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step)#42229

Merged
DilumAluthge merged 5 commits intomasterfrom
dpa/remove-asan-buildkite
Sep 13, 2021
Merged

CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step)#42229
DilumAluthge merged 5 commits intomasterfrom
dpa/remove-asan-buildkite

Conversation

@DilumAluthge
Copy link
Copy Markdown
Member

@DilumAluthge DilumAluthge commented Sep 13, 2021

Of the 20 most recent julia-master-experimental jobs on the master branch, 7 have passed and 13 have failed.

I don't think it's particularly useful to keep running a job that is this flaky. I would propose that we disable the asan job for now. Once we figure out how to get it to reliably pass, we can consider re-enabling it.

@DilumAluthge DilumAluthge added ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 13, 2021
@DilumAluthge DilumAluthge requested a review from a team as a code owner September 13, 2021 07:19
@DilumAluthge DilumAluthge removed the request for review from a team September 13, 2021 07:19
@tkf
Copy link
Copy Markdown
Member

tkf commented Sep 13, 2021 •
edited
Loading

Looking at the last 10 failures in the master branch https://buildkite.com/julialang/julia-master-experimental/builds?branch=master it looks like all of them failed on the Test that ASAN is enabled step. So, it looks like only my script for checking ASAN is failing. Maybe we can keep the build step? Since the compilation of the system images already runs under ASAN, I think the build step alone already is testing a substantial portion of the ASAN-enabled runtime.

tkf
tkf reviewed Sep 13, 2021
View reviewed changes
@DilumAluthge @tkf
Apply suggestions from code review
7ffad1e 
Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
@DilumAluthge DilumAluthge changed the title CI (Buildkite): disable the experimental asan job CI (Buildkite): in the experimental asan job, remove the contrib/asan/check.jl step (but keep the "Build julia-debug with ASAN" step) Sep 13, 2021
@DilumAluthge DilumAluthge requested a review from tkf September 13, 2021 08:00
@DilumAluthge
Copy link
Copy Markdown
Member Author

DilumAluthge commented Sep 13, 2021 •
edited
Loading

Let's give that a try.

@DilumAluthge DilumAluthge changed the title CI (Buildkite): in the experimental asan job, remove the contrib/asan/check.jl step (but keep the "Build julia-debug with ASAN" step) CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) Sep 13, 2021
tkf
tkf approved these changes Sep 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tkf tkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

@DilumAluthge DilumAluthge merged commit 60fd334 into master Sep 13, 2021
@DilumAluthge DilumAluthge deleted the dpa/remove-asan-buildkite branch September 13, 2021 21:16
KristofferC pushed a commit that referenced this pull request Sep 15, 2021
@DilumAluthge @tkf @KristofferC
CI (Buildkite): in the experimental asan job, remove the "Test that…
f2b96c7 
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
(cherry picked from commit 60fd334)
@KristofferC KristofferC mentioned this pull request Sep 15, 2021
Merged
84 tasks
KristofferC pushed a commit that referenced this pull request Sep 15, 2021
@DilumAluthge @tkf @KristofferC
CI (Buildkite): in the experimental asan job, remove the "Test that…
828adad 
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
(cherry picked from commit 60fd334)
@KristofferC KristofferC mentioned this pull request Sep 15, 2021
Merged
95 tasks
@DilumAluthge DilumAluthge mentioned this pull request Sep 16, 2021
Closed
This was referenced Oct 3, 2021
Merged
Merged
@KristofferC KristofferC mentioned this pull request Nov 8, 2021
Merged
66 tasks
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@DilumAluthge @tkf @KristofferC
CI (Buildkite): in the experimental asan job, remove the "Test that…
d783077 
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
(cherry picked from commit 60fd334)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@DilumAluthge @tkf @LilithHafner
CI (Buildkite): in the experimental asan job, remove the "Test that…
79ded78 
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229)

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@DilumAluthge @tkf @LilithHafner
CI (Buildkite): in the experimental asan job, remove the "Test that…
44146fa 
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229)

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@DilumAluthge @tkf @staticfloat
CI (Buildkite): in the experimental asan job, remove the "Test that…
2a9b710 
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>

Co-authored-by: Takafumi Arakaki <aka.tkf@gmail.com>
(cherry picked from commit 60fd334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staticfloat staticfloat Awaiting requested review from staticfloat

@vchuravy vchuravy Awaiting requested review from vchuravy

1 more reviewer

@tkf tkf tkf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci Continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DilumAluthge @tkf @KristofferC