CI (Buildkite, code coverage): Fail the code coverage job if the coverage is suspiciously low#42213
Merged
DilumAluthge merged 1 commit intomasterfrom Sep 11, 2021
Merged
Conversation
…rage is suspiciously low
Member
Author
|
Follow the build here: https://buildkite.com/julialang/julia-master-scheduled/builds/234 |
Codecov Report
@@ Coverage Diff @@
## master #42213 +/- ##
==========================================
+ Coverage 89.26% 89.28% +0.02%
==========================================
Files 351 351
Lines 78670 78664 -6
==========================================
+ Hits 70222 70239 +17
+ Misses 8448 8425 -23
Continue to review full report at Codecov.
|
Member
Author
|
The coverage build (https://buildkite.com/julialang/julia-master-scheduled/builds/234) passed. |
16 tasks
95 tasks
66 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…rage is suspiciously low (JuliaLang#42213)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…rage is suspiciously low (JuliaLang#42213)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally, we always pass the code coverage job.
However, if the coverage is suspiciously low (e.g. less than 50%), then this suggests that something went wrong earlier in the coverage job. Therefore, in those cases, we should fail the build to indicate that something has gone wrong somewhere in the code coverage pipeline.