Nothing comparison improvement in stdlib/Distributed/src/managers.jl#41881
Merged
aviatesk merged 1 commit intoJuliaLang:masterfrom Aug 13, 2021
Merged
Conversation
aviatesk
approved these changes
Aug 13, 2021
Member
aviatesk
left a comment
There was a problem hiding this comment.
These calls will be inlined to x === nothing by compiler, but I don't think it hurts anything if we manually inline them.
Contributor
Author
I didn't know that. Thanks!!. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is intended or not, but some codes in
stdlib/Distributed/src/managers.jlare using equality comparison (==) for nothing, not identical comparison (===).If this is not intended, I think later one should be used for small performance improvement.