Skip to content

MINSIGSTKSZ is no longer constant in glibc#41860

Merged
JeffBezanson merged 1 commit intoJuliaLang:masterfrom
t-bltg:minsigstksz
Aug 12, 2021
Merged

MINSIGSTKSZ is no longer constant in glibc#41860
JeffBezanson merged 1 commit intoJuliaLang:masterfrom
t-bltg:minsigstksz

Conversation

@t-bltg
Copy link
Copy Markdown
Contributor

@t-bltg t-bltg commented Aug 10, 2021

MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34.

Fix #41806.

Copy link
Copy Markdown
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comment mentions, we've seen empirically that this value is often too small. If we are removing the compile-time check here, we need to add it back as a runtime-check when we use the value.

MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Aug 11, 2021
@JeffBezanson JeffBezanson merged commit f19b9a2 into JuliaLang:master Aug 12, 2021
@t-bltg t-bltg deleted the minsigstksz branch August 12, 2021 20:18
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Aug 25, 2021
@vtjnash vtjnash added backport 1.7 backport 1.6 Change should be backported to release-1.6 labels Nov 2, 2021
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) starting from glibc 2.34

Co-authored-by: t-bltg <t-bltg@users.noreply.github.com>
(cherry picked from commit f19b9a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MINSIGSTKSZ is no longer a constant on Linux

5 participants