Conversation
stevengj
reviewed
Jun 30, 2021
stevengj
reviewed
Jun 30, 2021
vtjnash
approved these changes
Jul 2, 2021
Member
vtjnash
left a comment
There was a problem hiding this comment.
I made your comment into a suggestion. If you approve/commit that, I think we can immediately merge (i.e. add the merge-me tag)
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Member
|
Interestingly (for the type system), this made the humble call |
Member
Author
|
Scratch that, I just saw that #41511 already has a triage label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #33363.
This allows to concatenate matrices, numbers and uniform scalings.
Fixes JuliaLang/LinearAlgebra.jl#666. Closes #33363.