Skip to content

Fix log message id from at-deprecate to be a Symbol.#40820

Open
fredrikekre wants to merge 1 commit intomasterfrom
fe/deprecate-logging
Open

Fix log message id from at-deprecate to be a Symbol.#40820
fredrikekre wants to merge 1 commit intomasterfrom
fe/deprecate-logging

Conversation

@fredrikekre
Copy link
Copy Markdown
Member

No description provided.

@fredrikekre fredrikekre added logging The logging framework backport 1.6 Change should be backported to release-1.6 labels May 13, 2021
@fredrikekre fredrikekre force-pushed the fe/deprecate-logging branch from fa26381 to befb813 Compare May 17, 2021 07:26
@fredrikekre fredrikekre requested a review from c42f May 17, 2021 07:29
@fredrikekre
Copy link
Copy Markdown
Member Author

Tests fail because of top-level ids now beeing the same, xref #25158. Currently those tests pass because of === fallback comparing two identical frames, which seems brittle too. Should the patch in this PR instead generate a id from a hash of the frame or something?

@KristofferC KristofferC mentioned this pull request Jun 4, 2021
45 tasks
@vtjnash vtjnash closed this Jun 19, 2021
@vtjnash vtjnash reopened this Jun 19, 2021
@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Jun 19, 2021

Can you explain briefly what issue this will fix? The description above is blank. Re-running CI now, since we recently suffered a loss of all logs.

@fredrikekre
Copy link
Copy Markdown
Member Author

I had a log record struct with ::Symbol on the message id field but that broke for deprecation log messages. Perhaps the assumption that the id is always a symbol was wrong though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logging The logging framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants