Depwarn caller fix#25158
Merged
StefanKarpinski merged 2 commits intoJuliaLang:masterfrom Dec 21, 2017
Merged
Conversation
This seems generally more useful than returning the new one.
stevengj
approved these changes
Dec 18, 2017
Member
Author
|
CI failure seems unrelated... if potentially serious |
Member
|
cc @vtjnash ^ |
Member
Author
|
Can this be merged? It's a small bugfix, CI has passed, and I want to build some other things on top of it. |
Member
|
Should I squash or not? |
Member
Author
|
I think not, the two commits here represent distinct changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the core problem of #25130, namely that on occasion - and especially at top level scope - the internal dispatch or interpreter machinery was being blamed as the caller of a deprecated function.
Along the way I also noticed what was arguably a bug in
global_logger(logger), so that's also fixed to more usefully return the old logger rather than the replacement.