show(::String): elide long strings (close #40724)#40736
show(::String): elide long strings (close #40724)#40736StefanKarpinski merged 1 commit intomasterfrom
Conversation
a9a47b9 to
8dd4e1b
Compare
|
Well, I have no idea why the MPFR_jll tests are failing on this PR. I've run those tests locally and they pass just fine, which suggests an interaction between the MPFR_jll tests and some other tests. |
8dd4e1b to
78b13cf
Compare
|
Well, this is fun. I cannot reproduce the MPFR_jll failure locally. |
78b13cf to
535de85
Compare
535de85 to
909f4f9
Compare
|
What was happening with MPFR precompilation is likely that we use |
|
Shouldnt't this use |
|
The
|
|
Yea, behaves like I expected. My comment was based on reviewing the code before the last push. |
Wouldn't the |
|
I had that thought as well, but in my experiments, the |
|
Since this seems to have significant support and no objections and it's ready to go, I'm merging. |
|
It might be interesting to have a :compact flag that does something similar, but is even more substantially chopped off, for showing inside Matrixes and Tuples and such (I think Dict already does this automatically?), but this looks good to me! |
Still needs tests and I want to print the skip message in bold but
printstyleddoesn't nest properly, so that doesn't work. Also needs tests & news, but I thought I'd make a PR to see if this breaks any tests first.