Conversation
vtjnash
approved these changes
Apr 19, 2021
Member
vtjnash
left a comment
There was a problem hiding this comment.
is dropping the new eigvals!(A::SymTridiagonal{<:BlasReal}) definition intentional?
Member
Author
What do you mean? I haven't touched any |
Member
|
The PR this closes had an additional change to stdlib/LinearAlgebra/src/tridiag.jl not included here |
Member
Author
|
Oh, sorry, yes, that was fixed in #40165. That additional change was in fact superfluous because it shortened the |
45 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…Lang#40526) Co-authored-by: Marcelo Forets <mforets@gmail.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…Lang#40526) Co-authored-by: Marcelo Forets <mforets@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Jun 10, 2021
Co-authored-by: Marcelo Forets <mforets@gmail.com> (cherry picked from commit 3428e88)
KristofferC
pushed a commit
that referenced
this pull request
Jun 10, 2021
Co-authored-by: Marcelo Forets <mforets@gmail.com> (cherry picked from commit 3428e88)
KristofferC
pushed a commit
that referenced
this pull request
Jun 11, 2021
Co-authored-by: Marcelo Forets <mforets@gmail.com> (cherry picked from commit 3428e88)
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…Lang#40526) Co-authored-by: Marcelo Forets <mforets@gmail.com>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Co-authored-by: Marcelo Forets <mforets@gmail.com> (cherry picked from commit 3428e88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
eigvecs(::SymTridiagonal, eigvals), akaLAPACK.stein!, for longer off-diagonal vectors. Closes #38833.Co-authored-by: Marcelo Forets mforets@gmail.com