[RFC] Adding get(::Function, ::ImmutableDict, key) to resolve #40413#40471
Merged
vtjnash merged 3 commits intoJuliaLang:masterfrom Apr 19, 2021
Merged
[RFC] Adding get(::Function, ::ImmutableDict, key) to resolve #40413#40471vtjnash merged 3 commits intoJuliaLang:masterfrom
get(::Function, ::ImmutableDict, key) to resolve #40413#40471vtjnash merged 3 commits intoJuliaLang:masterfrom
Conversation
Removed trailing whitespace to fix buildbot error
Contributor
Author
|
The failures seems to be due to an error in the Sockets testset. I can't quite figure out the Stacktrace, but it does not seem to have any relation to the changes in the commits made here so I'm not sure how to fix this. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a function to
base/dict.jlto extendget()to accept a default function as argument, as discussed in, and to resolve #40413.Added tests to
test/dict.jl, in analogy with those defined forget(::Function, ::Dict, key).