ensure require_one_based_indexing can constant-fold for ranges#40358
Merged
ensure require_one_based_indexing can constant-fold for ranges#40358
Conversation
Refs performance issue noted in #38527
This was referenced Apr 6, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…Lang#40358) Refs performance issue noted in JuliaLang#38527
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…Lang#40358) Refs performance issue noted in JuliaLang#38527
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…Lang#40358) Refs performance issue noted in JuliaLang#38527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs performance issue noted in #38527
As noted there,
length(m:n)can throw exceptions, which makes that function quite costly. I'm not sure there is much we can do about that, other than change our ranges to be exclusive[)? 😬