Skip to content

Improve Cholesky docstrings#39964

Merged
dkarrasch merged 3 commits intomasterfrom
nl/cholesky
Mar 12, 2021
Merged

Improve Cholesky docstrings#39964
dkarrasch merged 3 commits intomasterfrom
nl/cholesky

Conversation

@nalimilan
Copy link
Copy Markdown
Member

The p object wasn't even documented.

The `p` object wasn't even documented.
@nalimilan nalimilan added docs This change adds or pertains to documentation linear algebra Linear algebra labels Mar 9, 2021

The triangular Cholesky factor can be obtained from the factorization `F::Cholesky`
via `F.L` and `F.U`.
via `F.L` and `F.U`, where `A ≈ F.U' * F.U ≈ F.L * F.L'`.
Copy link
Copy Markdown
Member Author

@nalimilan nalimilan Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples use == but I imagine only holds generally? Or maybe this may not even be exactly the case?

Co-authored-by: Daniel Karrasch <Daniel.Karrasch@gmx.de>
Co-authored-by: Daniel Karrasch <Daniel.Karrasch@gmx.de>
@dkarrasch dkarrasch merged commit fa7d792 into master Mar 12, 2021
@dkarrasch dkarrasch deleted the nl/cholesky branch March 12, 2021 14:05
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation linear algebra Linear algebra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants