add basic overview of when to use type declarations#39812
Merged
JeffBezanson merged 8 commits intomasterfrom Feb 25, 2021
Merged
add basic overview of when to use type declarations#39812JeffBezanson merged 8 commits intomasterfrom
JeffBezanson merged 8 commits intomasterfrom
Conversation
timholy
approved these changes
Feb 24, 2021
Member
timholy
left a comment
There was a problem hiding this comment.
This seems helpful and in the right place. There are other reasons to add types, but these are the most common and most relevant for newcomers.
Member
|
Maybe slightly less emphasis, though? Feels a bit like shouting, though I understand why these points are worth emphasizing. |
lungben
reviewed
Feb 24, 2021
Member
Author
|
With regard to bold/emphasized text, I was influenced a lot by Jakob Nielsen's usability studies, which suggests that online readers typically scan text rather than reading from top to bottom, and so it is useful to highlight key ideas in bold to aid scannability. However, I can certainly cut down on this if people prefer; I've already updated it to trim the emphases somewhat. Let me know if you want me to go further. |
Member
|
Nice! |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions about when to declare function arguments come up over and over on discourse, and so it seems useful to put a basic summary early in the chapter on Functions, rather than deferring it to later chapters.