Skip to content

faster Float16 sinh#39432

Merged
vtjnash merged 2 commits intoJuliaLang:masterfrom
oscardssmith:float16-hyperbolic
Apr 19, 2021
Merged

faster Float16 sinh#39432
vtjnash merged 2 commits intoJuliaLang:masterfrom
oscardssmith:float16-hyperbolic

Conversation

@oscardssmith
Copy link
Copy Markdown
Member

@oscardssmith oscardssmith commented Jan 28, 2021

Improves speed by not using Float64 arithmatic when we're going to round to Float16 soon. .5 ULP maximal error tested on all Float16 values.

@oscardssmith oscardssmith added float16 maths Mathematical functions performance Must go faster labels Jan 28, 2021
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 16, 2021
vtjnash
vtjnash approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@vtjnash vtjnash merged commit 6a40cf8 into JuliaLang:master Apr 19, 2021
@oscardssmith oscardssmith deleted the float16-hyperbolic branch April 19, 2021 12:50
vtjnash added a commit that referenced this pull request Apr 19, 2021
@vtjnash
enable new Float16 methods for sinh and cbrt
c2cca0a 
From #39432 and #39441, these were still using their old definition due
to method overwriting.
@vtjnash vtjnash mentioned this pull request Apr 19, 2021
Merged
vtjnash added a commit that referenced this pull request Apr 19, 2021
@vtjnash
enable new Float16 methods for sinh and cbrt
5a21363 
From #39432 and #39441, these were still using their old definition due
to method overwriting.
oscardssmith pushed a commit that referenced this pull request Apr 20, 2021
@vtjnash
enable new Float16 methods for sinh and cbrt (#40534)
5784cd3 
From #39432 and #39441, these were still using their old definition due
to method overwriting.
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Apr 28, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@oscardssmith @ElOceanografo
faster Float16 sinh (JuliaLang#39432)
9d82cb5
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@vtjnash @ElOceanografo
enable new Float16 methods for sinh and cbrt (JuliaLang#40534)
cb73abe 
From JuliaLang#39432 and JuliaLang#39441, these were still using their old definition due
to method overwriting.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@oscardssmith @antoine-levitt
faster Float16 sinh (JuliaLang#39432)
17fed57
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@vtjnash @antoine-levitt
enable new Float16 methods for sinh and cbrt (JuliaLang#40534)
690d5eb 
From JuliaLang#39432 and JuliaLang#39441, these were still using their old definition due
to method overwriting.
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@oscardssmith @johanmon
faster Float16 sinh (JuliaLang#39432)
eb28bfc
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@vtjnash @johanmon
enable new Float16 methods for sinh and cbrt (JuliaLang#40534)
3382c2b 
From JuliaLang#39432 and JuliaLang#39441, these were still using their old definition due
to method overwriting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees

No one assigned

Labels

float16 maths Mathematical functions performance Must go faster

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oscardssmith @vtjnash @simeonschaub