Fix GPUCodegen by re-inferring deleted methods#35655
Merged
Conversation
1ecaf79 to
802654b
Compare
802654b to
ecda2f9
Compare
maleadt
approved these changes
May 5, 2020
Member
maleadt
left a comment
There was a problem hiding this comment.
With this, CUDAnative.jl codegen tests pass again.
maleadt
added a commit
to JuliaGPU/GPUCompiler.jl
that referenced
this pull request
May 6, 2020
maleadt
added a commit
to JuliaGPU/GPUCompiler.jl
that referenced
this pull request
May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34993
In JIT compilation mode we delete the inferred method after emitting it. Normally AOT mode doesn't run concurrently with JIT mode, but GPUCodegen does concurrently and
we have stricter requirements since we need to collect all code reachable from the kernel.
This adds a second policy to
jl_create_nativein which upon encountering a deleted method we re-infer it as needed.