give IR forms for defining types valid linear structure#33553
Merged
JeffBezanson merged 1 commit intomasterfrom Apr 28, 2020
Merged
give IR forms for defining types valid linear structure#33553JeffBezanson merged 1 commit intomasterfrom
JeffBezanson merged 1 commit intomasterfrom
Conversation
Member
Author
|
It seems to me that if we break everything down into simpler forms, JuliaInterpreter can continue to work unmodified, which would certainly be a plus. |
c08e620 to
fe45bbb
Compare
ae8b12f to
27f96b8
Compare
27f96b8 to
c6d2acd
Compare
Member
|
Since you asked about JuliaInterpreter, the changes were relatively minor (though not entirely trivial to track down):
We'd noticed the former differences in lowering, and even had to handle them specially to make sure a performance optimization didn't trigger errors. So I'm supportive of this change. |
timholy
added a commit
that referenced
this pull request
May 2, 2020
timholy
added a commit
that referenced
this pull request
May 2, 2020
Member
|
Hooray! Thanks Jeff! Awesome. :) |
Contributor
|
Currently, eg. in Julia v1.5.2 it still remains a mention to those expr in (define (check-top-level e)
(define (head-to-text h)
(case h
((abstract_type) "\"abstract type\"")
((primitive_type) "\"primitive type\"")
((struct_type) "\"struct\"")
((method) "method definition")
(else (string "\"" h "\""))))@ https://github.com/JuliaLang/julia/blob/v1.5.2/src/julia-syntax.scm#L3786-L3790 I don't know if it is voluntary (for backward compat or something else), or an omission |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type-defining IR forms (
struct_typeetc.) are currently very special: they violate the usual linear structure rules for IR, and evaluate their arguments in a non-standard way intertwined with some global effects. This PR tries to clean that up, removing the special cases and hopefully eventually leading to fixing #33183.The new type-defining process here is broken into three steps at the IR level:
Uses only function calls (unfortunately requiring several new builtins though).
fixes #35416