Skip to content

fix #30124, broadcast regression due to removed pure annotation#30420

Merged
JeffBezanson merged 1 commit intomasterfrom
jb/fix30124
Dec 18, 2018
Merged

fix #30124, broadcast regression due to removed pure annotation#30420
JeffBezanson merged 1 commit intomasterfrom
jb/fix30124

Conversation

@JeffBezanson
Copy link
Copy Markdown
Member

@vtjnash confirms this is ok.

fix #30124

ref 9e98386

@JeffBezanson JeffBezanson added performance Must go faster broadcast Applying a function over a collection backport pending 1.1 labels Dec 17, 2018
@JeffBezanson JeffBezanson added this to the 1.1 milestone Dec 17, 2018
@martinholters
Copy link
Copy Markdown
Member

"A function may be annotated with @pure if and only if @vtjnash confirms it is ok to do so."---Docstring material?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Dec 17, 2018

Should perhaps also open an issue to reflect the optimization issue that this hacks around.

@JeffBezanson JeffBezanson merged commit e6938a0 into master Dec 18, 2018
@JeffBezanson JeffBezanson deleted the jb/fix30124 branch December 18, 2018 17:26
ViralBShah added a commit that referenced this pull request Dec 18, 2018
KristofferC pushed a commit that referenced this pull request Dec 20, 2018
@KristofferC KristofferC mentioned this pull request Dec 20, 2018
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

broadcast Applying a function over a collection performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance regression with StaticArray broadcast

4 participants