Skip to content

add Event; use it to fix race in Distributed setup#29623

Merged
JeffBezanson merged 2 commits intomasterfrom
jb/syncdistributed
Oct 19, 2018
Merged

add Event; use it to fix race in Distributed setup#29623
JeffBezanson merged 2 commits intomasterfrom
jb/syncdistributed

Conversation

@JeffBezanson
Copy link
Copy Markdown
Member

@JeffBezanson JeffBezanson commented Oct 13, 2018

This fixes the Distributed test failure in #22631 with partr enabled. See #22631 (comment) --- we were relying on scheduling order to make sure a setup message is sent first.

In my mind, an "event" is something that happens at a point in time, while a "condition" is something that can persist for a while. But as far as I can tell common terminology reverses them, and an event is level-triggered while a condition is edge-triggered. Go figure.

@JeffBezanson JeffBezanson added parallelism Parallel or distributed computation multithreading Base.Threads and related functionality labels Oct 13, 2018
@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Oct 15, 2018

In my mind, an "event" is something that happens at a point in time, while a "condition" is something that can persist for a while. But as far as I can tell common terminology reverses them, and an event is level-triggered while a condition is edge-triggered. Go figure.

Would it be too disruptive/confusing for us to use the terminology in a saner way than is conventional?

@JeffBezanson
Copy link
Copy Markdown
Member Author

JeffBezanson commented Oct 16, 2018

Would it be too disruptive/confusing for us to use the terminology in a saner way than is conventional?

Unfortunately, probably yes. AFAICT every systems book and API out there uses these terms.

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Oct 16, 2018

Sigh. This is why we can’t have nice things.

@JeffBezanson
Copy link
Copy Markdown
Member Author

JeffBezanson commented Oct 16, 2018

Ah, reset is taken and means something else. What should we call it? unsignal? unnotify?

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Oct 16, 2018

cancel?

@JeffBezanson
Copy link
Copy Markdown
Member Author

JeffBezanson commented Oct 16, 2018

Also seems to be common to call the paired operations set and clear.

@JeffBezanson
Copy link
Copy Markdown
Member Author

JeffBezanson commented Oct 17, 2018

Ok, for now I will leave out clear/reset since I don't actually need it yet.

@JeffBezanson JeffBezanson merged commit f6344d3 into master Oct 19, 2018
@JeffBezanson JeffBezanson deleted the jb/syncdistributed branch October 19, 2018 20:42
fredrikekre added a commit that referenced this pull request Nov 30, 2018
@fredrikekre
Compat annotation for #29623 (Event).
2a59a31
fredrikekre added a commit that referenced this pull request Nov 30, 2018
@fredrikekre
Compat annotation for #29623 (Event).
5ce8198
fredrikekre added a commit that referenced this pull request Dec 1, 2018
@fredrikekre
Compat annotation for #29623 (Event).
4e05d70
fredrikekre added a commit that referenced this pull request Dec 1, 2018
@fredrikekre
Compat annotation for #29623 (Event).
01eb5c6
fredrikekre added a commit that referenced this pull request Dec 3, 2018
@fredrikekre
Compat annotation for #29623 (Event).
fedaca5
fredrikekre added a commit that referenced this pull request Dec 4, 2018
@fredrikekre
Compat annotation for #29623 (Event).
d432d6c
fredrikekre added a commit that referenced this pull request Dec 4, 2018
@fredrikekre
Compat annotation for #29623 (Event).
cdd670f
fredrikekre added a commit that referenced this pull request Dec 5, 2018
@mortenpi @fredrikekre
Addition of NEWS and compat admonitions for important
cceb675 
changes between Julia 1.0 and 1.1, including:

- Custom .css-style for compat admonitions.

- Information about compat annotations to CONTRIBUTING.md.

- NEWS.md entry for PRs #30090, #30035, #30022, #29978,
  #29969, #29858, #29845, #29754, #29638, #29636, #29615,
  #29600, #29506, #29469, #29316, #29259, #29178, #29153,
  #29033, #28902, #28761, #28745, #28708, #28696, #29997,
  #28790, #29092, #29108, #29782

- Compat annotation for PRs #30090, #30013, #29978,
  #29890, #29858, #29827, #29754, #29679, #29636, #29623,
  #29600, #29440, #29316, #29259, #29178, #29157, #29153,
  #29033, #28902, #28878, #28761, #28708, #28156, #29733,
  #29670, #29997, #28790, #29092, #29108, #29782, #25278

- Documentation for broadcasting CartesianIndices (#30230).
- Documentation for Base.julia_cmd().
- Documentation for colon constructor of CartesianIndices (#29440).
- Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix).

- Run NEWS-update.jl.

Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre added a commit that referenced this pull request Dec 5, 2018
@mortenpi @fredrikekre
Addition of NEWS and compat admonitions for important
ebbabf5 
changes between Julia 1.0 and 1.1, including:

- Custom .css-style for compat admonitions.

- Information about compat annotations to CONTRIBUTING.md.

- NEWS.md entry for PRs #30090, #30035, #30022, #29978,
  #29969, #29858, #29845, #29754, #29638, #29636, #29615,
  #29600, #29506, #29469, #29316, #29259, #29178, #29153,
  #29033, #28902, #28761, #28745, #28708, #28696, #29997,
  #28790, #29092, #29108, #29782

- Compat annotation for PRs #30090, #30013, #29978,
  #29890, #29858, #29827, #29754, #29679, #29636, #29623,
  #29600, #29440, #29316, #29259, #29178, #29157, #29153,
  #29033, #28902, #28878, #28761, #28708, #28156, #29733,
  #29670, #29997, #28790, #29092, #29108, #29782, #25278

- Documentation for broadcasting CartesianIndices (#30230).
- Documentation for Base.julia_cmd().
- Documentation for colon constructor of CartesianIndices (#29440).
- Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix).

- Run NEWS-update.jl.

Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre added a commit that referenced this pull request Dec 5, 2018
@fredrikekre @mortenpi
Compat admonitions and NEWS for Julia 1.1 (#30230)
6175bd9 
Addition of NEWS and compat admonitions for important changes between Julia 1.0 and 1.1, including:

- Custom .css-style for compat admonitions.

- Information about compat annotations to CONTRIBUTING.md.

- NEWS.md entry for PRs #30090, #30035, #30022, #29978,
  #29969, #29858, #29845, #29754, #29638, #29636, #29615,
  #29600, #29506, #29469, #29316, #29259, #29178, #29153,
  #29033, #28902, #28761, #28745, #28708, #28696, #29997,
  #28790, #29092, #29108, #29782

- Compat annotation for PRs #30090, #30013, #29978,
  #29890, #29858, #29827, #29754, #29679, #29636, #29623,
  #29600, #29440, #29316, #29259, #29178, #29157, #29153,
  #29033, #28902, #28878, #28761, #28708, #28156, #29733,
  #29670, #29997, #28790, #29092, #29108, #29782, #25278

- Documentation for broadcasting CartesianIndices (#30230).
- Documentation for Base.julia_cmd().
- Documentation for colon constructor of CartesianIndices (#29440).
- Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix).

- Run NEWS-update.jl.


Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

multithreading Base.Threads and related functionality parallelism Parallel or distributed computation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JeffBezanson @StefanKarpinski