Merged
Conversation
omus
commented
Aug 4, 2018
| pkg.version = VersionSpec() | ||
| end | ||
| end | ||
| end |
Member
Author
There was a problem hiding this comment.
Using git diff --ignore-space-change this is more comprehensible:
diff --git a/stdlib/Pkg/src/Operations.jl b/stdlib/Pkg/src/Operations.jl
index 547cebdc75..63cf3ad6f2 100644
--- a/stdlib/Pkg/src/Operations.jl
+++ b/stdlib/Pkg/src/Operations.jl
@@ -1162,6 +1162,7 @@ end
function up(ctx::Context, pkgs::Vector{PackageSpec})
# resolve upgrade levels to version specs
new_git = UUID[]
+ Base.shred!(LibGit2.CachedCredentials()) do creds
for pkg in pkgs
if pkg.uuid in keys(ctx.stdlibs)
pkg.version = VersionSpec()
@@ -1172,7 +1173,8 @@ function up(ctx::Context, pkgs::Vector{PackageSpec})
info = manifest_info(ctx.env, pkg.uuid)
if info !== nothing && haskey(info, "repo-url")
pkg.repo = Types.GitRepo(info["repo-url"], info["repo-rev"])
- new = handle_repos_add!(ctx, [pkg]; upgrade_or_add = (level == UPLEVEL_MAJOR))
+ new = handle_repos_add!(ctx, [pkg]; credentials=creds,
+ upgrade_or_add = (level == UPLEVEL_MAJOR))
append!(new_git, new)
else
if info !== nothing
@@ -1192,6 +1194,7 @@ function up(ctx::Context, pkgs::Vector{PackageSpec})
end
end
end
+ end
# resolve & apply package versions
resolve_versions!(ctx, pkgs)
new_apply = apply_versions(ctx, pkgs)
ararslan
pushed a commit
that referenced
this pull request
Aug 4, 2018
Avoids asking the user for their credentials multiple times for the same domain. (cherry picked from commit 1dfc4d1)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids asking the user for their credentials multiple times for the same domain.