Merged
Conversation
waldyrious
reviewed
Aug 3, 2018
stdlib/Pkg/docs/src/index.md
Outdated
| Sometimes one might want to use some packages only at testing time but not | ||
| enforce a dependency on them when the package is used. This is possible by | ||
| adding `[extra]` dependencies and adding a a "test target" to the Project file. | ||
| adding `[extras]` dependencies and adding a a "test target" to the Project file. |
Contributor
There was a problem hiding this comment.
There's a duplicate "a" in adding a a "test target" in this line as well.
Also, I'd suggest formatting that bit as adding a "test" `[target]` (or adding a `[target]` named "test"), to be consistent with the usage of `[extras]` earlier in the sentence.
Member
StefanKarpinski
left a comment
There was a problem hiding this comment.
Thanks for the fix to [extras]. Note that the [targets] section is plural as well, however.
waldyrious
reviewed
Aug 3, 2018
| Sometimes one might want to use some packages only at testing time but not | ||
| enforce a dependency on them when the package is used. This is possible by | ||
| adding `[extra]` dependencies and adding a a "test target" to the Project file. | ||
| adding dependencies to `[extras]` and a `test` target in `[targets]` to the Project file. |
Contributor
There was a problem hiding this comment.
"to `[targets]`", rather than "in `[targets]`"?
ararslan
pushed a commit
that referenced
this pull request
Aug 4, 2018
* Update index.md (cherry picked from commit a451801)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.