disable FileWatching tests that fail on mac#28411
Merged
Conversation
19ae4a8 to
e22a7f0
Compare
Member
|
Alternatively, if Travis provides a High Sierra image, we could use that. I believe Jameson mentioned that the new Apple Filesystem introduced in High Sierra addresses that issue. |
Member
|
Seems it does: https://docs.travis-ci.com/user/reference/osx/#os-x-version |
Member
|
Eh, let's just disable this test. We can revisit enabling it in the future. |
KristofferC
pushed a commit
that referenced
this pull request
Aug 4, 2018
ararslan
pushed a commit
that referenced
this pull request
Aug 4, 2018
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, I am officially tired of these tests failing all the time. If we can't fix it we might as well disable them so our builds generally pass.
ref #26725