Skip to content

Remove the examples/ folder#26153

Merged
staticfloat merged 1 commit intomasterfrom
aa/no-more-examples
Mar 3, 2018
Merged

Remove the examples/ folder#26153
staticfloat merged 1 commit intomasterfrom
aa/no-more-examples

Conversation

@ararslan
Copy link
Copy Markdown
Member

@ararslan ararslan commented Feb 21, 2018

These have been moved to https://github.com/JuliaArchive/Examples.

@mauro3
Copy link
Copy Markdown
Contributor

mauro3 commented Feb 22, 2018

Maybe re-add the example removed in #25606, it could be of historical interest...

@ararslan ararslan requested a review from staticfloat February 23, 2018 00:26
be handled asynchronously.

Folder `examples/clustermanager/0mq` contains an example of using ZeroMQ to connect Julia workers
The folder `clustermanager/0mq` in the Examples repository contains an example of using ZeroMQ to connect Julia workers
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to actually link to the Examples repository here


# dumptype is for displaying abstract type hierarchies,
# based on Jameson Nash's examples/typetree.jl
# based on Jameson Nash's typetree.jl in JuliaArchive/Examples
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... in the GitHub repository JuliaArchive/Examples. Otherwise I might think this is a folder within this repository.

make -j3 VERBOSE=1 all
make -j3 VERBOSE=1 install
make VERBOSE=1 -C examples
make VERBOSE=1 -C test/embedding release
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this instead:

make VERBOSE=1 JULIA=usr/bin/julia.exe BIN=test/embedding -C test/embedding release

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make: Entering directory '/cygdrive/c/projects/julia/test/embedding'
make: usr/bin/julia.exe: Command not found
make: usr/bin/julia.exe: Command not found
cc /cygdrive/c/projects/julia/test/embedding/embedding.c -o test/embedding/embedding.exe     -lm  
make: cc: Command not found
make: *** [Makefile:36: test/embedding/embedding.exe] Error 127
make: Leaving directory '/cygdrive/c/projects/julia/test/embedding'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makefile isn't intended to be called directly from inside the Julia tree. That's why embedding/Makefile existed to read in the configuration variables from Make.inc and forward them to the example.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. We just need to find a way to compile the embedding test's C code while building Julia so that a compiler isn't needed to run the embedding test. (Unless that's okay.)

@ararslan ararslan force-pushed the aa/no-more-examples branch 3 times, most recently from 5f8ff73 to 5ae9eff Compare March 1, 2018 19:37
@ararslan ararslan force-pushed the aa/no-more-examples branch from 5ae9eff to 1ec6cd9 Compare March 2, 2018 20:38
@ararslan
Copy link
Copy Markdown
Member Author

ararslan commented Mar 3, 2018

32-bit Windows failure is #26280

@ararslan
Copy link
Copy Markdown
Member Author

ararslan commented Mar 3, 2018

@staticfloat Does this look okay now?

@staticfloat staticfloat merged commit 87492e8 into master Mar 3, 2018
@ararslan ararslan deleted the aa/no-more-examples branch March 3, 2018 20:04
mbauman added a commit that referenced this pull request Mar 5, 2018
…luenonscalarindexedassignment

* origin/master: (28 commits)
  fix an optimizer bug in `invoke` with non-constant functions (#26301)
  lower top-level statements in such a way that the front-end knows (#26304)
  Make sure Sockets page has h1 header (#26315)
  fix doctests, and make them less prone to errors (#26275)
  FIx intro to manual chapter on types (#26312)
  Add a missing "that" (#26313)
  fix docstring for code_llvm (#26266)
  Remove the examples/ folder (#26153)
  download cert.pem from deps-getall, fixes #24903 (#25344)
  Slight update to doc string for at-enum to refer to instances (#26208)
  performance tweak in reverse(::String) (#26300)
  remove references to `TCPSocket` in Base docstrings (#26298)
  Deprecate adding integers to CartesianIndex (#26284)
  Deprecate conj(::Any), add real(::Missing) and imag(::Missing) (#26288)
  fix #26267, regression in `names` with `imported=false` (#26293)
  fix #25857, `typeinfo` problem in showing arrays with abstract tuple types (#26289)
  Add adjoint(::Missing) method (#25502)
  Use lowered form in logging macro (#26291)
  deprecate bin, oct, dec, hex, and base in favor of `string` and keyword args (#25804)
  deprecate `spawn(cmd)` to `run(cmd, wait=false)` (#26130)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants