camel-case iteratorsize and iteratoreltype#25402
Merged
JeffBezanson merged 1 commit intomasterfrom Jan 7, 2018
Merged
Conversation
This matches other traits better.
ararslan
approved these changes
Jan 5, 2018
Member
|
Will there be any possibility of a performance regression since the functions are no longer precompiled? |
Member
Author
|
We need to update the precompile files anyway (#24666). |
Member
|
+1 While we're at it we should decide whether it's a good convention that traits start with |
Member
Author
|
Those names sound backwards to me; I'd expect |
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
This matches other traits better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches other traits better.