Merged
Conversation
StefanKarpinski
approved these changes
Aug 9, 2017
Sacha0
reviewed
Aug 9, 2017
base/deprecated.jl
Outdated
| end | ||
|
|
||
| # PR #23187 | ||
| @deprecate cpad(s, n::Integer, p=" ") rpad(lpad(s,div(n+strwidth(s),2),p),n,p) false |
Member
There was a problem hiding this comment.
A few more spaces might improve readability? :)
Sacha0
reviewed
Aug 9, 2017
base/pkg/entry.jl
Outdated
| function warnbanner(msg...; label="[ WARNING ]", prefix="") | ||
| cols = Base.displaysize(STDERR)[2] | ||
| warn(prefix="", Base.cpad(label,cols,"=")) | ||
| str = rpad(lpad(label,div(cols+strwidth(label),2),"="),cols,"=") |
Member
There was a problem hiding this comment.
Likewise here, a few spaces might improve readability :).
Sacha0
reviewed
Aug 9, 2017
NEWS.md
Outdated
| * Calling `union` with no arguments is deprecated; construct an empty set with an appropriate | ||
| element type using `Set{T}()` instead ([#23144]). | ||
|
|
||
| * `Base.cpad` is removed; use appropriate combination of `rpad` and `lpad` instead ([#23187]). |
Member
There was a problem hiding this comment.
Perhaps "is removed" -> "has been removed" or "is deprecated", and perhaps "use appropriate" -> "use an appropriate"? :)
Sacha0
approved these changes
Aug 9, 2017
Member
Sacha0
left a comment
There was a problem hiding this comment.
Thanks for the followup review request! That's a great approach :).
Member
Author
|
Double time-out on travis... |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #22184 / #22186