Refactor cpad functionality to match lpad and rpad#22186
Closed
djsegal wants to merge 1 commit intoJuliaLang:masterfrom
Closed
Refactor cpad functionality to match lpad and rpad#22186djsegal wants to merge 1 commit intoJuliaLang:masterfrom
djsegal wants to merge 1 commit intoJuliaLang:masterfrom
Conversation
Member
|
I think that we should not be exporting cpad at all – we should delete it instead. The only use of |
Author
|
Sounds good to me I just thought it needed to match the other two or get deleted // as a side reference, this might be an interesting read: how lpad broke the internet |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: