julia-mode: Add space to prompt regexp#15135
Conversation
|
LGTM, is there a way to test this other than checking for the content of |
|
I looked into the problem from that bug report a bit and the issue is related to emacs repositioning the cursor to the wrong place. For Besides simulating the problem, I don't see an easy way to test this at the moment. We just want the output from the process, which does have the extra space, to be consistent with the regexp. |
|
fwiw ess-julia uses this regexp |
|
I think julia-mode currently doesn't really support other REPL mode ( |
|
ok, let me change it On Thu, Feb 18, 2016 at 12:48 PM Yichao Yu notifications@github.com wrote:
|
Fixes JuliaLang#14002 The primary problem was the lack of a space at the end of the regexp, which didn't match the output of the shell process (does have a space). This meant that emacs sometimes placed the point one character before the end of the buffer, which prevented M-p from working. This new regexp also allows for other prompts, such as "shell> "
970242f to
400710c
Compare
|
ok, I fixed it. I just amended the commit. Hope that's ok On Thu, Feb 18, 2016 at 12:49 PM Justin Burkett justin@burkett.cc wrote:
|
Yep, this is the preferred way of updating a pull request. |
julia-mode: Add space to prompt regexp
|
Verified locally that this works. If someone can come up with an easy way to test this against the output of the julia REPL we can always add it later =). |
|
Sounds good. Thanks On Thu, Feb 18, 2016 at 1:01 PM Yichao Yu notifications@github.com wrote:
|
Fixes #14002