Skip to content

patches #13682 to fix memory mapping of large files on Windows#15125

Merged
tkelman merged 1 commit intoJuliaLang:masterfrom
Cody-G:cjg/fix_mmap_win
Feb 18, 2016
Merged

patches #13682 to fix memory mapping of large files on Windows#15125
tkelman merged 1 commit intoJuliaLang:masterfrom
Cody-G:cjg/fix_mmap_win

Conversation

@Cody-G
Copy link
Copy Markdown
Contributor

@Cody-G Cody-G commented Feb 17, 2016

Fixes #13560

This was referenced Feb 17, 2016
Closed
Closed
@quinnj
Copy link
Copy Markdown
Member

quinnj commented Feb 17, 2016

I still don't think this is right; the docs say that all the args for CreateFileMapping are DWORD. Do you know which function/argument is specifically causing problems for you?

@yuyichao
Copy link
Copy Markdown
Contributor

yuyichao commented Feb 17, 2016

I think the argument is still DWORD but the convertion to a integer before getting it's higher and lower 32bits was the issue.

@quinnj
Copy link
Copy Markdown
Member

quinnj commented Feb 17, 2016

Ah.....that makes sense.

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Feb 17, 2016

lgtm. we've been reluctant to add tests for this since it requires making a 4GB+ file. but I assume you've at least tested this locally to show that it is giving the right results?

@Cody-G
Copy link
Copy Markdown
Contributor Author

Cody-G commented Feb 17, 2016

Yes, I've tested it with large imaging datasets, and it looks good. If the mapping was incorrect it should have been obvious in the images.

@tkelman
Copy link
Copy Markdown
Contributor

tkelman commented Feb 18, 2016

We could try adding an automated outside-of-base regression test for this running in a dedicated repository on appveyor?

@tkelman
Copy link
Copy Markdown
Contributor

tkelman commented Feb 18, 2016

Travis failure is a cache corruption, will restart

In file included from /usr/include/limits.h:27:0,
                 from /usr/lib/gcc/x86_64-linux-gnu/4.6/include-fixed/limits.h:169,
                 from /usr/lib/gcc/x86_64-linux-gnu/4.6/include-fixed/syslimits.h:7,
                 from /usr/lib/gcc/x86_64-linux-gnu/4.6/include-fixed/limits.h:34,
                 from /home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/src/os-linux.c:26:
/usr/include/features.h:324:26: fatal error: bits/predefs.h: No such file or directory
compilation terminated.
43.236308 libtool: compile:  gcc -march=pentium4 -m32 -DHAVE_CONFIG_H -I. -I/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/src -I../include -I/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/include -I/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/include/tdep-x86 -I. -D_GNU_SOURCE -DNDEBUG -U_FORTIFY_SOURCE -fPIC -fexceptions -Wall -Wsign-compare -MT mi/init.lo -MD -MP -MF mi/.deps/init.Tpo -c /home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/src/mi/init.c -o mi/init.o
In file included from /home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/src/mi/init.c:26:0:
/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/include/libunwind_i.h:49:75: fatal error: sys/types.h: No such file or directory
compilation terminated.
make[5]: *** [os-linux.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
make[5]: *** [mi/init.lo] Error 1
43.312240 libtool: compile:  gcc -march=pentium4 -m32 -DHAVE_CONFIG_H -I. -I/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/src -I../include -I/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/include -I/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/include/tdep-x86 -I. -D_GNU_SOURCE -DNDEBUG -U_FORTIFY_SOURCE -fPIC -fexceptions -Wall -Wsign-compare -MT mi/flush_cache.lo -MD -MP -MF mi/.deps/flush_cache.Tpo -c /home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/src/mi/flush_cache.c -o mi/flush_cache.o
In file included from /home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/src/mi/flush_cache.c:26:0:
/home/travis/build/JuliaLang/julia/deps/srccache/libunwind-1.1-julia2/include/libunwind_i.h:49:75: fatal error: sys/types.h: No such file or directory
compilation terminated.
``

tkelman added a commit that referenced this pull request Feb 18, 2016
@tkelman
Merge pull request #15125 from Cody-G/cjg/fix_mmap_win
fabec7b 
patches #13682 to fix memory mapping of large files on Windows
@tkelman tkelman merged commit fabec7b into JuliaLang:master Feb 18, 2016
tkelman pushed a commit that referenced this pull request Mar 7, 2016
@Cody-G @tkelman
patches #13682 to fix memory mapping of large files on Windows
3770c61 
(cherry picked from commit 73a572c)
ref #15125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

system:windows Affects only Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Cody-G @quinnj @yuyichao @vtjnash @tkelman