Skip to content

RFC: added os_only documentation#15108

Merged
tkelman merged 1 commit intoJuliaLang:masterfrom
morris25:add_os_only_documentation
Feb 18, 2016
Merged

RFC: added os_only documentation#15108
tkelman merged 1 commit intoJuliaLang:masterfrom
morris25:add_os_only_documentation

Conversation

@morris25
Copy link
Copy Markdown
Contributor

The unix_only, linux_only, osx_only, and windows_only macros were missing documentation in the manual.

@tkelman tkelman added the docs This change adds or pertains to documentation label Feb 16, 2016
@tkelman
Copy link
Copy Markdown
Contributor

tkelman commented Feb 16, 2016

This looks good, though needs a rebase. Maybe the "Handling Operating System Variation" stuff should be its own section instead of part of "Calling C and Fortran"?

@morris25
Copy link
Copy Markdown
Contributor Author

I have split off Handling Operating System Variation into it's own section and rebased. Thanks for the feedback.
(I experienced some weirdness with the commit but all should be well now)

@morris25
Copy link
Copy Markdown
Contributor Author

The commits have now been squashed.

tkelman added a commit that referenced this pull request Feb 18, 2016
@tkelman tkelman merged commit 279586b into JuliaLang:master Feb 18, 2016
@tkelman
Copy link
Copy Markdown
Contributor

tkelman commented Feb 18, 2016

Thanks for these! Keep an eye on the rendered readthedocs version for nightly to make sure it all looks right in the final version.

@morris25 morris25 deleted the add_os_only_documentation branch February 18, 2016 20:12
@morris25 morris25 restored the add_os_only_documentation branch February 18, 2016 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants