Added tests to increase coverage in base/rationals.jl#15105
Merged
StefanKarpinski merged 1 commit intoJuliaLang:masterfrom Feb 18, 2016
pkofod:master
Merged
Added tests to increase coverage in base/rationals.jl#15105StefanKarpinski merged 1 commit intoJuliaLang:masterfrom pkofod:master
StefanKarpinski merged 1 commit intoJuliaLang:masterfrom
pkofod:master
Conversation
Contributor
|
These look good, thanks! I believe you can run CoverageBase locally. Automated coverage reporting is broken until we can get the OSX buildbot to pass tests again. |
Contributor
Author
|
Okay. I tried unsuccessfully, but I will try to figure out how it works. Thanks for the pointer though. |
Member
|
LGTM. Thanks for adding tests, which are always welcome :). |
Member
|
Yes, thank you – more test coverage is always lovely! |
StefanKarpinski
added a commit
that referenced
this pull request
Feb 18, 2016
Added tests to increase coverage in base/rationals.jl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would only be rational to increase the test coverage, if only by a fraction. (I'm,..., sorry)
I hope the tests are in the spirit of Julia tests. They are quite simple, but then again, the functions being tested are also quite simple.
What is the best way to see the code coverage in Base functionality before making a PR or merging?
Comments and criticism is much welcomed.