Skip to content

add test for recurring precompile#3361

Merged
IanButterworth merged 1 commit intoJuliaLang:masterfrom
IanButterworth:ib/precompile_recurring_test
Feb 4, 2023
Merged

add test for recurring precompile#3361
IanButterworth merged 1 commit intoJuliaLang:masterfrom
IanButterworth:ib/precompile_recurring_test

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

@IanButterworth IanButterworth commented Feb 4, 2023

Adds test for #3355

Should have been fixed by #3359 so I've temporarily reverted that commit to check tests fail

cc. @aviatesk

@IanButterworth IanButterworth force-pushed the ib/precompile_recurring_test branch from c3282c7 to ff6a36f Compare February 4, 2023 19:03
@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Feb 4, 2023

Ok, test fails without #3359 as expected

Issue 3359: Recurring precompile: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/api.jl:259
  Expression: !(occursin("Precompiling", String(take!(iob))))
   Evaluated: !(occursin("Precompiling", "Precompiling project...\n\e[32m  ✓ \e[39m\e[90mTableTraits\e[39m\n\e[32m  ✓ \e[39m\e[90mPooledArrays\e[39m\n\e[32m  ✓ \e[39m\e[90mCodecZlib\e[39m\n\e[32m  ✓ \e[39m\e[90mSnoopPrecompile\e[39m\n\e[32m  ✓ \e[39m\e[90mFilePathsBase\e[39m\n\e[32m  ✓ \e[39m\e[90mTables\e[39m\n\e[32m  ✓ \e[39m\e[90mParsers\e[39m\n\e[32m  ✓ \e[39m\e[90mInlineStrings\e[39m\n\e[32m  ✓ \e[39m\e[90mWeakRefStrings\e[39m\n\e[32m  ✓ \e[39mCSV\n  10 dependencies successfully precompiled in 26 seconds. 10 already precompiled.\n"))
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:477 [inlined]
 [2] (::Main.PkgTestsOuter.PkgTestsInner.APITests.var"#31#47")(tmp::String)
   @ Main.PkgTestsOuter.PkgTestsInner.APITests ~/work/Pkg.jl/Pkg.jl/test/api.jl:259

@IanButterworth IanButterworth force-pushed the ib/precompile_recurring_test branch from ff6a36f to d71339a Compare February 4, 2023 19:28
@IanButterworth IanButterworth merged commit ed505db into JuliaLang:master Feb 4, 2023
@IanButterworth IanButterworth deleted the ib/precompile_recurring_test branch February 4, 2023 20:15
@IanButterworth IanButterworth mentioned this pull request Feb 5, 2024
Merged
@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Feb 6, 2024

It turns out this CSV.jl commit has a significant bug in it that causes JuliaLang/julia#53192 to fail. Is there some way to now fix this CSV code to remove the bad commit or to do something simpler for a test here?

@IanButterworth
Copy link
Copy Markdown
Member Author

IanButterworth commented Feb 6, 2024

Feel free to revert this test and open an issue. I can investigate from there

vtjnash added a commit that referenced this pull request Feb 6, 2024
@vtjnash
Revert "add test for recurring precompile"
98f0313 
There seems to be a bug in this CSV code that can break precompile due to Base changes.
Reverts ed505db
Refs #3361
Refs #3359
@vtjnash vtjnash mentioned this pull request Feb 6, 2024
Merged
@IanButterworth IanButterworth mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IanButterworth @vtjnash