Don't assume that SubString has pointer and copy instead#506
Merged
LilithHafner merged 5 commits intomainfrom Oct 6, 2024
Merged
Don't assume that SubString has pointer and copy instead#506LilithHafner merged 5 commits intomainfrom
SubString has pointer and copy instead#506LilithHafner merged 5 commits intomainfrom
Conversation
Still assume `Substring{String}` has `pointer`
Add tests
for compuat with 1.2 and earlier
KristofferC
reviewed
Sep 16, 2024
Member
|
The test failure here seems to just be one CI machine having a bad day 🤷♀️ |
c42f
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…ng/JuliaSyntax.jl#506) * Don't assume that `SubString` has `pointer` and copy instead * Still assume `Substring{String}` has `pointer` * Test with `Test.GenericString`
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…ng/JuliaSyntax.jl#506) * Don't assume that `SubString` has `pointer` and copy instead * Still assume `Substring{String}` has `pointer` * Test with `Test.GenericString`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substring{String}haspointerFixes #505