tokenize.jl: don‘t hardcode unicode ops range#404
Closed
pthariensflame wants to merge 1 commit intoJuliaLang:mainfrom
Closed
tokenize.jl: don‘t hardcode unicode ops range#404pthariensflame wants to merge 1 commit intoJuliaLang:mainfrom
pthariensflame wants to merge 1 commit intoJuliaLang:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 94.61% 96.54% +1.92%
==========================================
Files 14 14
Lines 4178 4195 +17
==========================================
+ Hits 3953 4050 +97
+ Misses 225 145 -80 ☔ View full report in Codecov by Sentry. |
7ace8d7 to
488072f
Compare
Member
|
Heya, we just moved JuliaSyntax into Base in JuliaLang/julia#59870 - if you want to re-propose this PR over there, I've created a branch https://github.com/JuliaLang/JuliaSyntax.jl/tree/pr-for-Base/404 to make this easier. To make use of the branch, you can use the following steps:
For example: # git clone git@github.com:JuliaLang/julia julia_dir
# cd julia_dir
git remote add JuliaSyntax git@github.com:JuliaLang/JuliaSyntax.jl
git fetch JuliaSyntax
git checkout pr-for-Base/404
git rebase origin/masterSorry this wasn't dealt with prior to the big move! |
Keno
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 22, 2025
There are very nice `(BEGIN|END)_UNICODE_OPS` kinds; they should be used! --- Ported from JuliaLang/JuliaSyntax.jl#404; thanks are due to @c42f for the notification and instructions on how to move this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are very nice
(BEGIN|END)_UNICODE_OPSkinds; they should be used!