bring back Julia 1.0 compatibility#968
Merged
johnnychen94 merged 3 commits intomasterfrom Jul 28, 2021
Merged
Conversation
To reduce CI workload, for windows and macOS, we only test if it works on Julia 1.x release. This should expose most of the problem given that Images.jl is now an umbrella project.
johnnychen94
commented
Jul 28, 2021
Comment on lines
-10
to
-11
| schedule: | ||
| - cron: '20 00 1 * *' |
Member
Author
There was a problem hiding this comment.
The schedule job is removed because otherwise Github Actions will disable the CI automatically after 30/60 days of inactivity.
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
==========================================
+ Coverage 85.96% 86.04% +0.08%
==========================================
Files 9 9
Lines 1026 1025 -1
==========================================
Hits 882 882
+ Misses 144 143 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts #948 by bringing back Julia 1.0 compatibility.
The only reason that Images requires 1.3 was due to ImageIO but now we can get a dummy ImageIO v0.0.1 for the old Julia version. A drawback of this change is that now users of old Julia versions (i.e., <1.3) might again meet some binary dependency installation issues, but given that the recommended solution is to "use the latest Julia release", I don't think this drawback will be a pain.
FWIW, I also documented the guarantee and non-guarantee of Images compatibility for reference purposes. This exact statement is not discussed in previous history but there're some similar thoughts. (e.g., #824 (comment))
cc: @IanButterworth