Skip to content

add io backends ImageIO and ImageMagick as dependencies#948

Merged
johnnychen94 merged 3 commits intomasterfrom
jc/io
Apr 3, 2021
Merged

add io backends ImageIO and ImageMagick as dependencies#948
johnnychen94 merged 3 commits intomasterfrom
jc/io

Conversation

@johnnychen94
Copy link
Copy Markdown
Member

@johnnychen94 johnnychen94 commented Mar 28, 2021 •
edited
Loading

QuartzImageIO is not added for two reasons: 1) it only works for macOS, and 2) it has less functionality than ImageMagick.

Note that the julia compat "1" now becomes a fake one as the declared ImageIO and ImageMagick compatibility versions require Julia >= v"1.3"

@timholy Another thing that catches my interest: since TestImages >= v"1.2" are also backed by artifacts, could we also reexport this package in Images.jl? (One more step to make Images an umbrella package)

closes #24
closes #824

@johnnychen94
add io backends ImageIO and ImageMagick as dependencies
0011ecb 
QuartzImageIO is not added for two reasons: 1) it only works for macOS,
and 2) it has less functionality than ImageMagick.

The julia compat "1" now becomes a fake one as the declared ImageIO and
ImageMagick compatibility versions require Julia 1.3+
@johnnychen94 johnnychen94 requested a review from timholy March 28, 2021 04:51
@johnnychen94
set Julia compat to 1.3
34abf5a 
also replace Julia 1.0 with Julia 1.3 in our CI tests
@johnnychen94
Copy link
Copy Markdown
Member Author

johnnychen94 commented Mar 28, 2021

I think we now need to test four Julia versions in CI:

  • 1.3: the lowest version that we claim compatible
  • 1: the latest stable version, which happens to be 1.6 right now.
  • 1.6: the latest LTS version
  • nightly: to early find out upstream breaking changes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2021 •
edited
Loading

Codecov Report

Merging #948 (34abf5a) into master (810480a) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 34abf5a differs from pull request most recent head 62421d9. Consider uploading reports for the commit 62421d9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
- Coverage   86.21%   86.20%   -0.02%     
==========================================
  Files           9        9              
  Lines        1023     1022       -1     
==========================================
- Hits          882      881       -1     
  Misses        141      141
Impacted Files Coverage Δ
src/compat.jl 0.00% <0.00%> (-50.00%) ⬇️
src/corner.jl 87.69% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810480a...62421d9. Read the comment docs.

@johnnychen94
Copy link
Copy Markdown
Member Author

johnnychen94 commented Apr 3, 2021

Since we've already discussed this in #824 (comment) I'll just merge this version. It's not a breaking version, but since it restricts the Julia compatibility to 1.3, I bumped the minor version here. I don't plan to tag a release for this immediately, so I add the -dev suffix.

@johnnychen94 johnnychen94 merged commit 76f63f5 into master Apr 3, 2021
@johnnychen94 johnnychen94 deleted the jc/io branch April 3, 2021 07:34
@johnnychen94 johnnychen94 mentioned this pull request Jun 5, 2021
Merged
This was referenced Jul 23, 2021
Merged
Merged
@kimikage kimikage mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timholy timholy Awaiting requested review from timholy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImageMagick should be in the [deps] section in Project.toml Move away from ImageMagick

1 participant

@johnnychen94