Skip to content

Update examples.md to use ZipArchives#1158

Merged
quinnj merged 1 commit intoJuliaData:mainfrom
nhz2:patch-1
Mar 28, 2025
Merged

Update examples.md to use ZipArchives#1158
quinnj merged 1 commit intoJuliaData:mainfrom
nhz2:patch-1

Conversation

@nhz2
Copy link
Copy Markdown
Contributor

@nhz2 nhz2 commented Mar 18, 2025

I don't think ZipFile.jl is being maintained anymore, so I am updating the example to use ZipArchives.jl

This should also fix @JakeZw 's issue in fhs/ZipFile.jl#109

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (9f95cfb) to head (1491bb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files           9        9           
  Lines        2319     2319           
=======================================
  Hits         2101     2101           
  Misses        218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nhz2!

@quinnj quinnj merged commit 04ec1cf into JuliaData:main Mar 28, 2025
11 checks passed
@nhz2 nhz2 deleted the patch-1 branch March 29, 2025 01:32
@JakeZw
Copy link
Copy Markdown

JakeZw commented Aug 14, 2025

When I review the updated example, I fail to find where the file has been closed after the ZipReader command. ZipArchive says it needs to be closed in https://docs.juliahub.com/General/ZipArchives/stable/autodocs/ under the
ZipArchives.zip_openentry entry, the reading is not using the do block format.

Am I missing something?

Edit: Perhaps the ZipArchives documentation is wrong or I don't understand it, because when I try to close this construct the close(z) gives an error. Your example appears to be right.

quinnj pushed a commit that referenced this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants