Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.25%. Comparing base (66a3a65) to head (ea8796f).

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   90.41%   90.25%   -0.17%     
==========================================
  Files           9        9              
  Lines        2305     2308       +3     
==========================================
- Hits         2084     2083       -1     
- Misses        221      225       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The good news is that the library prrcompiles on nightly, the bad news is that it fails 😅. I'm gonna check what is wrong

@ViralBShah the tests now pass on nightly. the doc errors are due to Documenter 1.0 strict setting. another PR for that is coming.

@oscardssmith Is this good to merge (since you brought this to my attention)?

It looks reasonable to me. The entire getbytebuffer should probably be removed entirely since it's a function who's whole purpose is to violate the IOBuffer abstraction, but within the current framework, this seems like a good fix.

I'll merge for now to fix the breakage elsewhere.

Needs a new version for breakage to be fixed.

I've kicked off a new release